Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stage-4 Apps #111

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Add Stage-4 Apps #111

merged 1 commit into from
Feb 17, 2021

Conversation

Ornias1993
Copy link
Member

@Ornias1993 Ornias1993 commented Feb 16, 2021

Description

This PR adds a number of Apps:

  • Sabnzbd
  • NZBGET
  • headheadend
  • navidrome
  • Deluge

All of which are relatively straight k8s-at-home ports.

Fixes #53

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Manually and automatic

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works

Signed-off-by: Kjeld Schouten-Lebbing kjeld@schouten-lebbing.nl

@Ornias1993
Copy link
Member Author

@tprelog This time the review request was NOT a mistake ;-)

@Ornias1993
Copy link
Member Author

@tprelog the thing about those line endings:
I guess it's do to different platforms using different lineendings and the conversion between the two going wrong in some cases.

@tprelog
Copy link
Contributor

tprelog commented Feb 17, 2021

lgtm now

@Ornias1993
Copy link
Member Author

@tprelog I think you don't really know how the Github Review system works?
Normally you hit the "start review" button at your first comment, you make all your comments and "add" them to the review, afterwards in the top-right corner you either "request chages" "comment"(neutral option) or "approve" the PR.

If the requested changes are made, you can go to the same big green review button and select "approve", instead of commenting LGTM. I can override it, but normally the merge button is locked untill you hit that button.

@Ornias1993
Copy link
Member Author

navidrome: Works
Deluge: works. pass = admin/deluge.
nzbget: works. pass = nzbget/tegbzn6789
Sabnzbd: works but hostname verification error (future fix with init container?)

Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
@Ornias1993
Copy link
Member Author

Removed Octoprint due to the upstream chart seeming to be broken:
Error: Invalid value for '--port': tcp://172.17.139.156:80 is not a valid integer

@Ornias1993
Copy link
Member Author

All remaining charts working now

@tprelog
Copy link
Contributor

tprelog commented Feb 17, 2021

@tprelog I think you don't really know how the Github Review system works?

You would be correct. I'm trying to figure it out as I go

Normally you hit the "start review" button at your first comment, you make all your comments and "add" them to the review, afterwards in the top-right corner you either "request chages" "comment"(neutral option) or "approve" the PR.

If the requested changes are made, you can go to the same big green review button and select "approve", instead of commenting LGTM.

Thanks for the quick HowTo -- I'll do this next time

@Ornias1993
Copy link
Member Author

@tprelog Awesome, no big deal :)

@Ornias1993 Ornias1993 deleted the Stage-4 branch February 19, 2021 13:54
Ornias1993 pushed a commit that referenced this pull request Mar 31, 2021
Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
Ornias1993 pushed a commit that referenced this pull request Mar 31, 2021
Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
ellienieuwdorp pushed a commit to ellienieuwdorp/charts that referenced this pull request Apr 10, 2021
Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

Co-authored-by: Troy Prelog <35702532+tprelog@users.noreply.github.com>
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SabNZBD
3 participants