Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(charts): Replace broken links for Paperless-NGX/Jellyfin #12487

Merged
merged 5 commits into from
Sep 11, 2023
Merged

docs(charts): Replace broken links for Paperless-NGX/Jellyfin #12487

merged 5 commits into from
Sep 11, 2023

Conversation

aamirazad
Copy link
Contributor

Description

⚒️ Fixes links on jellyfin and paperless-ngx charts.

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

N/A

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@aamirazad aamirazad requested review from Ornias1993 and a team as code owners September 11, 2023 13:40
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@StevenMcElligott StevenMcElligott enabled auto-merge (squash) September 11, 2023 13:47
@aamirazad
Copy link
Contributor Author

I'm new to this. Is it an issue that I didn't increase the version? All I changed is the documentation. If I need to change the version, I don't know how to.

@StevenMcElligott
Copy link
Member

I'm new to this. Is it an issue that I didn't increase the version? All I changed is the documentation. If I need to change the version, I don't know how to.

Don't worry, not necessary, it's more if you change the actual code for other files (especially the values or templates that could affect running of the chart). However the lint CI test will make it fail anyways. Once someone else approves it'll get merged but won't be seen until catalog gets pushed again

@StevenMcElligott StevenMcElligott changed the title Replace broken links and fixe spelling docs(charts): Replace broken links for Paperless-NGX/Jellyfin Sep 11, 2023
@StevenMcElligott
Copy link
Member

Also @stavros-k can you add @aamirazad as a contributor for docs with @all-contributors, thanks!

@stavros-k
Copy link
Member

@all-contributors please add @aamirazad for docs

@stavros-k stavros-k merged commit 56b03aa into truecharts:master Sep 11, 2023
7 of 8 checks passed
@allcontributors allcontributors bot mentioned this pull request Sep 11, 2023
Merged
stavros-k pushed a commit that referenced this pull request Sep 11, 2023
@allcontributors
docs: add aamirazad as a contributor for doc (#12495)
f5e1a78 
Adds @aamirazad as a contributor for doc.

This was requested by stavros-k [in this
comment](#12487 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@allcontributors
Copy link
Contributor

@stavros-k

I've put up a pull request to add @aamirazad! 🎉

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StevenMcElligott StevenMcElligott StevenMcElligott approved these changes

@Ornias1993 Ornias1993 Awaiting requested review from Ornias1993 Ornias1993 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aamirazad @CLAassistant @StevenMcElligott @stavros-k @truecharts-admin