[Common] Refactor Services #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ornias1993
force-pushed
the
service-refactor
branch
4 times, most recently
from
f7cee40
to
ec0fab1
Compare
|
Services are Refactored and Unittests should be passing now. Unit-Tests for more than the first Service require a very significant addon to the testing system, hence are delayed untill a later date. TODO:
|
Ornias1993
force-pushed
the
service-refactor
branch
from
9744dfb
to
2e909e5
Compare
|
Should be mostly done, just needs some tests to finish and maybe some bugtracing. |
Ornias1993
force-pushed
the
service-refactor
branch
from
a4a3693
to
5c8ba43
Compare
added 2 commits
March 3, 2021 15:32
- services (dict, including main service) - additionalServices (list)
tprelog
approved these changes
Mar 3, 2021
Ornias1993
force-pushed
the
service-refactor
branch
from
5c8ba43
to
9f0ba8f
Compare
|
Awesome, thanks for the review @tprelog |
added 2 commits
March 3, 2021 15:42
Ornias1993
pushed a commit
that referenced
this pull request
Mar 3, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
Ornias1993
pushed a commit
that referenced
this pull request
Mar 3, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
Ornias1993
pushed a commit
that referenced
this pull request
Mar 12, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
Ornias1993
pushed a commit
that referenced
this pull request
Mar 17, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
Ornias1993
pushed a commit
that referenced
this pull request
Mar 31, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
Ornias1993
pushed a commit
that referenced
this pull request
Mar 31, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
ellienieuwdorp
pushed a commit
to ellienieuwdorp/charts
that referenced
this pull request
Apr 10, 2021
* Refactor All Services - services (dict, including main service) - additionalServices (list) * Add Documentation and standardised questions.yaml layout for services * Update all existing Apps to 2.0.0 * Fix whiteline error * fix addons
|
This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the services and breaks support with current code.
Hence it's merged into
StagingnotMaster.Stagingwill be merged when next TrueNAS SCALE release hitsIt aims to rework the services in a more sustainable fassion
Fixes #211
Type of change
How Has This Been Tested?
Notes:
Checklist: