Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Convert fit-form component to classic layout #48

Merged
merged 2 commits into from Dec 18, 2019

Conversation

steveszc
Copy link
Contributor

Purpose

Fixes #47

Approach

Converts fit-form component from pods layout to classic layout

Learning

https://cli.emberjs.com/release/advanced-use/project-layouts/

Addons should only use the classic structure for compatibility with either classic or pods-based consuming applications.

@steveszc
Copy link
Contributor Author

@flexyford Mind giving this a quick look?

@flexyford
Copy link
Contributor

Happy to merge this, but a couple of tests relied on pod structure. Mind fixing those up as well?

@steveszc steveszc force-pushed the steveszc/issue-47/classic-layout branch from 62bb42d to d04013e Compare December 18, 2019 00:42
@steveszc
Copy link
Contributor Author

@flexyford Oops I missed the required updates to the /app directory files.
Looks like theres still one test failing now, and its also failing locally.

Unit | Component | form-adapters/ember-changeset/ember-changeset-validations > with a model with validations > validate the form: validating an invalid form fails the validation step

Not really clear to me why that particular assertion would fail due to these changes.

@flexyford
Copy link
Contributor

After looking into this, we found that this test is failing in master and we suspect it is due to an bugfix in poteto/ember-changeset#378.

We are going to merge to file structure update and fix the test prior to a 2.0.0 release.

@flexyford flexyford merged commit 6c6c6b4 into truecoach:master Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants