Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new player version #32

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Conversation

jeyk
Copy link

@jeyk jeyk commented Nov 15, 2018

With a recent update of the Netflix player, this extension stopped working and caused error messages on playback.
I updated the player version and merged the changes. This player seems to work OK for me.

This should fix #29.

@Kono14
Copy link

Kono14 commented Nov 15, 2018

nice, such a simple fix. I love it
@truedread Please merge and push the update to the chrome store. At least until you find a better solution.

@TimoMeijer TimoMeijer mentioned this pull request Nov 15, 2018
@matt-scudder
Copy link

I grabbed this extension from your branch @jeyk and it solved the issue with most content, but I believe there's trouble still with content which doesnt have 1080p available.
ran into this with gurren laggen and kill la kill, and i get the following error code:
M7353-5101

console looks like

Manifest locked to Edge (or not available in 1080p)
cadmium-playercore-6.0011.474.011-1080p.js:29433 Getting Edge manifest
VM2415:194 Performing key exchange
VM2415:196 Key exchange data:
VM2415:197 {headerdata: {…}, encryptionKeyData: {…}, signKeyData: {…}}
VM2415:87 Getting video metadata for ID 70305056
VM2415:98 Metadata response:
VM2415:99 {version: "2.1", video: {…}, trackIds: {…}}
VM2415:364 Manifest:
VM2415:365 {success: true, serverTime: 1542333093363, result: {…}}
cadmium-playercore-6.0011.474.011-1080p.js:29435 Acquisition successful, commence playback

followed by a long hang and the M7353-5101 code from netflix

@truedread
Copy link
Owner

M7353-5101 is basically an MSE decoder timeout error, which is very interesting. It might have something to do with the 5.1 AAC track. I'll look into it, but on other videos locked to Edge it seems to work fine.

@pguedes
Copy link

pguedes commented Nov 16, 2018

also getting this M7353-5101 on some titles: Colony S1E2, Mechanism S1E8 but not others Narcos S2E2 or The Kominsky Method play fine on 1080p and 5.1 audio

@lbogdan
Copy link

lbogdan commented Nov 16, 2018

I can confirm it works here (just in time for "Narcos Mexico"! 😃 ).

@LatGeek
Copy link

LatGeek commented Nov 16, 2018

Was surprised with Error Code: M7111-1331-2206 today and I'm very glad to see it's already been fixed, looking forward to version 1.10.

@nra1871
Copy link

nra1871 commented Nov 17, 2018

Could somebody please help with instructions on how to solve this problem? I understand the player version for netflix has been updated and code for the extension needs to reflect that? I am no programmer whatsoever, I would really appreciate a step by step how to for resolving this problem.

@fahri314
Copy link

Could somebody please help with instructions on how to solve this problem? I understand the player version for netflix has been updated and code for the extension needs to reflect that? I am no programmer whatsoever, I would really appreciate a step by step how to for resolving this problem.

Use this pr. This is work. One episode average 700mb. episode size before update 2gb. With this pr 1.1 gb.
Download here > https://github.com/jeyk/netflix-1080p/tree/update-cadmium-player
and then use unpacked extension button in chrome. i hope truedread will update extension.

@Cysioland
Copy link

Yeah, this one works.

@shugo-chara
Copy link

error code:M7353-5101
Chrome 70

@tjiagoM
Copy link

tjiagoM commented Nov 17, 2018

Will this fix be available in chrome webstore instead of us having to manually download things to chrome?

@nra1871
Copy link

nra1871 commented Nov 17, 2018

I cannot get the extension to work. I completely removed the 1.9 version. Used the developer mode to load unpacked extension, cleared browser cache, opened up Chrome again, still cannot get it to work.

@Kono14
Copy link

Kono14 commented Nov 17, 2018

solution: just use another browser for the time being until this extension gets an official update. I use Edge just for Netflix (which I already used before I found this extension).
Saves you time and trouble getting this to fix to work. Anyway it wouldn't work for everything.

@Cysioland
Copy link

@Kono14 Hard to use Edge on GNU/Linux. Anyway, pulled this patch, installed manually and it works.

@ryanmusante
Copy link

ryanmusante commented Nov 17, 2018

@Cysioland use this dedicated player with the same 1080p patch. He's always checking to ensure compatibility with truedread's latest version. It's in the AUR but it installs easily into other distributions.

@truedread Thank you for your work!

https://github.com/gort818/qtwebflix

screenshot from 2018-11-18 02-19-26

@om26er
Copy link

om26er commented Nov 17, 2018

@nra1871 you are right, it was working fine for me yesterday with this branch but today it's not working anymore.

@jeyk
Copy link
Author

jeyk commented Nov 17, 2018

Unfortunately, it stopped working for me, too. Yesterday, I could play Dr. Who just fine, today I cannot. I fixed a mistake I made by mixing up the obfuscated variable names, but this didn't help.

For some shows, it works, while for others it doesn't.

@om26er
Copy link

om26er commented Nov 17, 2018

@jeyk With a very small set of testing I found that videos that are not 16:9 show the error, while 16:9 content plays fine.

@jeyk
Copy link
Author

jeyk commented Nov 17, 2018

@om26er I can't confirm that. Dr. Who is 16:9 and shows the error, while Star Trek: The Next Generation is not 16:9, but plays fine. Also, Paradise P.D. is 16:9, but plays fine nonetheless.

@Cysioland
Copy link

Spongebob Squarepants doesn't play. The Good Place and Narcos plays, though.

@s-ff
Copy link

s-ff commented Nov 18, 2018

Works fine with some shows.

@nra1871
Copy link

nra1871 commented Nov 20, 2018

I was just going to wait things out and install an official updated extension through the Chrome Web Store. For some reason though, I decided to try this updated extension by jeyk again, not sure why, I had it tried so many times before without any luck. Now it's working just fine as it should. Only difference I can notice is that Netflix updated it's player with added functionality of fast forward and reverse by 10 seconds, and just the overall feel and look has been tweaked. I'm sure it works well for many shows, and some content is just not going to work as usual. Anyways, hopefully this does not need to be messed with again for quite some time.

@nhockey
Copy link

nhockey commented Nov 20, 2018

Could somebody please help with instructions on how to solve this problem? I understand the player version for Netflix has been updated and code for the extension needs to reflect that? I am no programmer whatsoever, I would really appreciate a step by step how to for resolving this problem.

There are a couple ways to try out the branch that has the new player core but please note this new player core is still having problems with some titles on Netflix and you will most likely be toggling it on and off quite a bit.

Acquisition of the patched extension:
Method 1 ( or the "point and click method")

  1. go to https://github.com/jeyk/netflix-1080p/tree/update-cadmium-player
  2. click the green "Clone or Download" button and choose "Download ZIP"
  3. Open the zip file and extract the "Netflix-1080p-update-cadmium-player" folder someplace you will remember. I don't recommend putting it on the desktop; we have home directories for a reason. :) I put mine in "%UserProfile%\Sources" on windows and "$HOME/Sources/" on POSIX like systems. (These folders won't exits, you will have to create them.)

Method 2 (Using git in the console... or "I like to learn things I might not have known"):

  1. (optional) make a directory for storing sources. If you decide to do this step make sure you enter the new directory before the next step.
  2. git clone https://github.com/jeyk/netflix-1080p.git jeyk-netflix-1080p
  3. cd jeyk-netflix-1080p
  4. (optional) git branch -a
  5. git checkout update-cadmium-player
    git workflow

Installation of the extension

  1. in the address bar enter "chrome://extensions" or wade your way through the "three dot menu" thing going to "More tools" and then choosing "Extensions"
  2. On the top right of the extensions page, there is a lil switch, feel free to toggle that on enabling developer mode.
  3. Now on the spiffy new bar that apears choose "Load unpacked"
  4. Simply navigate to the folder that you either checked out using git or extracted from the zip file and hit the Okay button.
  5. Disable the official extension, there is no reason to remove it:
    official extension off
  6. Enable the new one and if ya get an "unexpected error" remember this isn't perfect and only works on some titles.
    unpacked extension on
    (Note: the little orange circle in the corner of the extensions icon, that means it's an "unpacked extension" and I prefer to leave my development extensions this way so they are easily distinguishable.)

@truedread
Copy link
Owner

I'll merge and update for now until I can find a better solution.

@truedread truedread merged commit 27b4b6c into truedread:master Nov 21, 2018
@jeyk jeyk deleted the update-cadmium-player branch November 21, 2018 18:10
@nra1871
Copy link

nra1871 commented Nov 22, 2018

nhockey, I got the thing installed and working, but I do appreciate the fully laid out professional like documentation for downloading and installing an extension the manual way. Helping out the uninitiated does not go by unacknowledged or unappreciated. You went above and beyond on your response and hopefully others will benefit for the effort put in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After Resuming a show getting unknown error