Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-121200 / 23.10 / Add adguard-home to community train #1061

Merged
merged 8 commits into from
Apr 11, 2023

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Mar 27, 2023

No description provided.

@stavros-k stavros-k added WIP Work In Progress jira labels Mar 27, 2023
@stavros-k stavros-k self-assigned this Mar 27, 2023
@bugclerk bugclerk changed the title Add adguard-home to community train NAS-121200 / 23.10 / Add adguard-home to community train Mar 27, 2023
@bugclerk
Copy link
Contributor

@stavros-k stavros-k force-pushed the adguard_community branch 3 times, most recently from 47f4f8c to aaad4b9 Compare March 29, 2023 12:06
@stavros-k stavros-k marked this pull request as ready for review March 29, 2023 12:08
@stavros-k stavros-k removed the WIP Work In Progress label Apr 7, 2023
path: "$kubernetes-resource_configmap_portal_path"

questions:
# - variable: adguardRunAs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# FIXME: It might be able to run rootless, probably blocked by:
# https://github.com/AdguardTeam/AdGuardHome/issues/4681

Don't know yet if when the issue above is solved it will be able to run as arbitrary user.

@stavros-k stavros-k merged commit 341ec42 into master Apr 11, 2023
9 checks passed
@stavros-k stavros-k deleted the adguard_community branch April 11, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants