-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD-324: add enterprise info to minio app articles #1872
Merged
Mrt134
merged 8 commits into
master
from
PD-324-Add-Enterprise-Info-to-MinIO-App-Articles
Apr 19, 2023
Merged
PD-324: add enterprise info to minio app articles #1872
Mrt134
merged 8 commits into
master
from
PD-324-Add-Enterprise-Info-to-MinIO-App-Articles
Apr 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the MinioManualUpdate.md file adding a summary procedure linking the individual instruction sections to each step, and changes the section headers for the instructions to gerund form. It also adds the known workarounds for host path validation and turning off share service before deploying the app, then restarting the service after the app is running.
This commit adds a new navigation section for Enterprise Applications and creates the /Apps/EnterpriseApps/_indext.md file. It creates a new tutorial article for MinIO Enterprise users in the new section for Enterprise Apps. It also moves the existing EnterpriseApplicationsSCALE.md article to the new section for Enterprise applications It makes a few minor edits to the UI reference article. Finally, it changes the navigation weights for the application tutorials to get them in the right order with the Enterprise Articles at the top of the list under Apps.
Mrt134
changed the title
Pd 324 add enterprise info to min io app articles
PD-324: add enterprise info to min io app articles
Apr 18, 2023
Mrt134
changed the title
PD-324: add enterprise info to min io app articles
PD-324: add enterprise info to minio app articles
Apr 18, 2023
Mrt134
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I've got a few polish comments/suggestions.
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/EnterpriseApps/ConfigMinioEnterprise.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/MinIOClustersSCALE/MinIOClustering.md
Outdated
Show resolved
Hide resolved
content/SCALE/SCALETutorials/Apps/MinIOClustersSCALE/MinIOClustering.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Moore <Mrt134@users.noreply.github.com>
Co-authored-by: Tim Moore <Mrt134@users.noreply.github.com>
Thank you for the polish points! I did have to fix some stray ``` in the first article but other than that, all comments committed! |
Mrt134
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the SCALE Tutorial Applications articles navigation. It adds a new expand section for Enterprise Applications, and changes the weights of the other tutorial articles to have them display below the new section. The new _index.md article still needs a nuanced statement about Enterprise Apps verses Official Chart Apps.
It moves the existing EnterpriseApplicationsSCALE.md article to the new section, and adds a new article for configuring MinIO Official Enterprise using the minio wizard.
It updates content in the MinIO Official Charts tutorials. Adds a procedure overview to the MinioManualUpdate.md article, and updates content in MinIOClusterin.md article and replaces or removes out of date docker image screenshots.
It makes minor corrections in the Ui Ref article AppsScreensSCALE.md.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.