Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-293: truetable shortcode and consistent markdown table styling #1880

Merged
merged 15 commits into from
May 1, 2023

Conversation

Mrt134
Copy link
Collaborator

@Mrt134 Mrt134 commented Apr 28, 2023

This introduces the truetable shortcode to allow all existing markdown tables to be modified and adopt a consistent style across the website.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This shortcode allows passing a .css class to the markdown table.

Usage:
```
{{< table style="class" >}}
```
"class" needs to be defined in custom.css before we can begin using this.
Add {{< truetable >}} wrapper around markdown tables and build test.
@Mrt134 Mrt134 changed the title PD-293: truetable shortcode and consistent styling PD-293: truetable shortcode and consistent markdown table styling Apr 28, 2023
@Mrt134 Mrt134 marked this pull request as ready for review April 28, 2023 18:09
@Mrt134 Mrt134 requested a review from a team as a code owner April 28, 2023 18:09
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the tables don't render with the new shortcode, tables in expand-within-expands and tabs in CORE articles, and one in a SCALE UI that should work is in reporting screen/ general options table.

@micjohnson777 micjohnson777 added the Technical Writer Review (MJ) A technical writer is reviewing the PR. label Apr 28, 2023
@micjohnson777 micjohnson777 merged commit 6118c03 into master May 1, 2023
3 checks passed
@micjohnson777 micjohnson777 deleted the PD-293-containersizingfixes branch May 1, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Writer Review (MJ) A technical writer is reviewing the PR.
Projects
None yet
2 participants