-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD-293: truetable shortcode and consistent markdown table styling #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shortcode allows passing a .css class to the markdown table. Usage: ``` {{< table style="class" >}} ``` "class" needs to be defined in custom.css before we can begin using this.
Add {{< truetable >}} wrapper around markdown tables and build test.
Mrt134
changed the title
PD-293: truetable shortcode and consistent styling
PD-293: truetable shortcode and consistent markdown table styling
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the tables don't render with the new shortcode, tables in expand-within-expands and tabs in CORE articles, and one in a SCALE UI that should work is in reporting screen/ general options table.
micjohnson777
added
the
Technical Writer Review (MJ)
A technical writer is reviewing the PR.
label
Apr 28, 2023
micjohnson777
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the truetable shortcode to allow all existing markdown tables to be modified and adopt a consistent style across the website.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.