Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-293: Image compress and other ahrefs-based improvements #1890

Merged
merged 6 commits into from
May 9, 2023

Conversation

Mrt134
Copy link
Collaborator

@Mrt134 Mrt134 commented May 5, 2023

After a fresh test, attempt to address several of the complaints from Ahrefs:

  • Reoptimize images for faster loading pages.
  • Fix historical links that currently 404
  • Fix additional image 404s
  • Add Open Graph and Twitter metadata templates for better site indexability/searchability/findability in social networks.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

After a fresh test, attempt to address several of the complaints from Ahrefs:
- Reoptimize images for faster loading pages.
- Fix historical links that currently 404
- Fix additional image 404s
@Mrt134 Mrt134 requested a review from a team as a code owner May 5, 2023 18:24
@Mrt134 Mrt134 marked this pull request as draft May 5, 2023 18:25
@Mrt134 Mrt134 marked this pull request as ready for review May 8, 2023 11:54
@Mrt134 Mrt134 marked this pull request as draft May 8, 2023 11:54
@Mrt134 Mrt134 marked this pull request as ready for review May 8, 2023 19:34
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this even though there are two suggested fixes in a test of the feedback button. We can do the fixes in that ticket so we can approve this one.

@micjohnson777 micjohnson777 added the Technical Writer Review (MJ) A technical writer is reviewing the PR. label May 8, 2023
@micjohnson777 micjohnson777 merged commit 8249b8e into master May 9, 2023
3 checks passed
@micjohnson777 micjohnson777 deleted the PD-293-imageconvert branch May 9, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Writer Review (MJ) A technical writer is reviewing the PR.
Projects
None yet
2 participants