PD-370 Update Storj Content #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the content with suggested changes made in the PR review.
This commit changes the wording of the front matter description parameter.
|
Added both Rehan and Stavros to provide a technical review of the changes requested by Morgan and verify the instructions provided in this PR are correct. |
|
I think I was asked for a review by mistake. I've tagged my namesake from the middleware team for a review. If I was not tagged by mistake, please let me know. |
|
I tagged you for a technical review of the content to make sure I have this
correct. We talked about it in a DM.
…On Tue, May 23, 2023 at 3:29 PM RehanY147 ***@***.***> wrote:
I think I was asked for a review by mistake. I've tagged my namesake from
the middleware team for a review. If I was not tagged by mistake, please
let me know.
—
Reply to this email directly, view it on GitHub
<#1917 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWDR2RH7EMHX7JRH635GDLLXHUFYDANCNFSM6AAAAAAYL4JXW4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
micjohnson777
added
the
Version Specific
Mrt134
removed
the
Version Specific
|
I don't see anything wrong! Just an addition, if the identity is not present on the storage directory, it will generate and authorize one automatically. |
Added Stavros suggested comments about identies.
|
@micjohnson777 there are a number of conflicts to review and make sure the correct content is merging in to master. |
This commit pushes the locally-saved version of this article to the github version after conflicts and missing content was restored. Some changes were not restored in that process.
…truenas/documentation into PD-370-Update-Storj-App-Content
|
Conflicts finally resolved but some feedback comments/commits might be lost. This needs the once-over again. |
Mrt134
approved these changes
May 31, 2023
Mrt134
added a commit
that referenced
this pull request
Jun 1, 2023
commit 9e4c683 Merge: c4a1c03 4e986b4 Author: MicJ <92740932+micjohnson777@users.noreply.github.com> Date: Wed May 31 17:42:33 2023 -0400 Merge pull request #1945 from truenas/editpagelinkfix Fix up "Edit Page" links at top of pages. commit 4e986b4 Merge: e991208 c4a1c03 Author: Tim Moore <Mrt134@users.noreply.github.com> Date: Wed May 31 16:21:46 2023 -0400 Merge branch 'master' into editpagelinkfix commit e991208 Author: Tim Moore <Mrt134@users.noreply.github.com> Date: Wed May 31 16:21:23 2023 -0400 Fix up "Edit Page" links at top of pages. Switch parameter to allow edit page links at bottom to continue to work as well. commit c4a1c03 Merge: 452d04d a24015f Author: Tim Moore <Mrt134@users.noreply.github.com> Date: Wed May 31 15:57:52 2023 -0400 Merge pull request #1944 from truenas/Mrt134-patch-3 Update COREReleaseNotes.md commit a24015f Author: Tim Moore <Mrt134@users.noreply.github.com> Date: Wed May 31 15:54:42 2023 -0400 Update COREReleaseNotes.md Add issue link that was erroneously marked as private commit 452d04d Merge: 3e711b0 dc463c0 Author: Tim Moore <Mrt134@users.noreply.github.com> Date: Wed May 31 10:44:14 2023 -0400 Merge pull request #1917 from truenas/PD-370-Update-Storj-App-Content PD-370 Update Storj Content commit dc463c0 Merge: 396b01f e78d6e9 Author: MicJ <mjohnson@ixsystems.com> Date: Wed May 31 09:10:59 2023 -0400 Merge branch 'PD-370-Update-Storj-App-Content' of https://github.com/truenas/documentation into PD-370-Update-Storj-App-Content commit 396b01f Merge: dea0ab2 3e711b0 Author: MicJ <mjohnson@ixsystems.com> Date: Wed May 31 09:08:41 2023 -0400 Merge branch 'master' into PD-370-Update-Storj-App-Content commit dea0ab2 Author: MicJ <mjohnson@ixsystems.com> Date: Wed May 31 08:58:27 2023 -0400 PD-370 Push Changes After Conflict Resolution This commit pushes the locally-saved version of this article to the github version after conflicts and missing content was restored. Some changes were not restored in that process. commit e78d6e9 Merge: 6022f96 3e711b0 Author: Tim Moore <Mrt134@users.noreply.github.com> Date: Wed May 31 08:49:40 2023 -0400 Merge branch 'master' into PD-370-Update-Storj-App-Content commit 6022f96 Author: MicJ <92740932+micjohnson777@users.noreply.github.com> Date: Fri May 26 16:34:48 2023 -0400 Update AddStorjNode.md Added Stavros suggested comments about identies. commit 69701de Author: MicJ <mjohnson@ixsystems.com> Date: Tue May 23 09:19:33 2023 -0400 PD-370 Correct description This commit changes the wording of the front matter description parameter. commit 9f12f81 Author: MicJ <mjohnson@ixsystems.com> Date: Tue May 23 09:10:05 2023 -0400 PD-370 Update Content This commit updates the content with suggested changes made in the PR review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the content with suggested changes made in the PR review. PR was merged too soon and before technical review. This PR makes changes to that content.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.