Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-487: Update TrueNAS Security Best Practices #1947

Merged
merged 8 commits into from
Jun 2, 2023

Conversation

Mrt134
Copy link
Collaborator

@Mrt134 Mrt134 commented Jun 1, 2023

This adds a general best practices section in front of the specific service hardening content and reweights headers for better navigation.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

content/Solutions/Optimizations/Security.md Outdated Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Outdated Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Outdated Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Outdated Show resolved Hide resolved
Polish from review comments
@Mrt134 Mrt134 requested a review from kmoore134 June 1, 2023 18:08
kmoore134
kmoore134 previously approved these changes Jun 1, 2023
@Mrt134 Mrt134 marked this pull request as ready for review June 1, 2023 18:24
@Mrt134 Mrt134 requested a review from a team as a code owner June 1, 2023 18:24
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix style issues in sections mentioned in comments above the section I could not add the comments to.

content/Solutions/Optimizations/Security.md Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Show resolved Hide resolved
@micjohnson777 micjohnson777 added the Technical Writer Review (MJ) A technical writer is reviewing the PR. label Jun 1, 2023
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullet list had two points that were not observing parallel construction. Made suggestions for a way to change the two points.

content/Solutions/Optimizations/Security.md Outdated Show resolved Hide resolved
content/Solutions/Optimizations/Security.md Outdated Show resolved Hide resolved
Mrt134 and others added 2 commits June 2, 2023 08:10
Co-authored-by: MicJ <92740932+micjohnson777@users.noreply.github.com>
Co-authored-by: MicJ <92740932+micjohnson777@users.noreply.github.com>
@Mrt134 Mrt134 requested a review from micjohnson777 June 2, 2023 12:11
@micjohnson777 micjohnson777 merged commit 13e35d7 into master Jun 2, 2023
3 checks passed
@micjohnson777 micjohnson777 deleted the PD-487-general_security_bestpractices branch June 2, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Writer Review (MJ) A technical writer is reviewing the PR.
Projects
None yet
3 participants