Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pd 1037 virtual machine instructions for networking incomplete #2515

Merged

Conversation

DjP-iX
Copy link
Contributor

@DjP-iX DjP-iX commented Mar 8, 2024

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

@DjP-iX DjP-iX requested a review from a team as a code owner March 8, 2024 15:20
@Mrt134 Mrt134 added the Review (TM) A technical writer is reviewing the PR. label Mar 8, 2024
- Rework admonition to be introductory content
- Rewrite first subsection as a numbered step procedure
- Add placeholder comment for second subsection to write a numbered step procedure for the other method to configure VM networking.
Update some of the admonitions.
Copy link
Collaborator

@Mrt134 Mrt134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great reworks! One item left to look at with a small numbered procedure for setting up VM networking on a secondary NIC, but the rest of the changes look fine.

@Mrt134 Mrt134 merged commit f80ca27 into master Mar 11, 2024
3 checks passed
@Mrt134 Mrt134 deleted the PD-1037-virtual-machine-instructions-for-networking-incomplete branch March 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review (TM) A technical writer is reviewing the PR.
Projects
None yet
2 participants