Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-125932 / 23.10.2 / Fix non-physical interface link address getting into database when it is updated #12813

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

themylogin
Copy link
Contributor

No description provided.

@bugclerk bugclerk changed the title Fix non-physical interface link address getting into database when it is updated NAS-125932 / 23.10.2 / Fix non-physical interface link address getting into database when it is updated Dec 28, 2023
@bugclerk
Copy link
Contributor

1 similar comment
@bugclerk
Copy link
Contributor

@yocalebo yocalebo merged commit 7196722 into stable/cobia Dec 28, 2023
1 of 2 checks passed
@yocalebo yocalebo deleted the fix-link-address branch December 28, 2023 11:31
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 28, 2023
@themylogin
Copy link
Contributor Author

time 2:00

@bugclerk
Copy link
Contributor

Time tracking failed:

  File "/home/bugclerk/bugclerk/__main__.py", line 960, in track_time
    comment.create_reaction('+1')
  File "/home/bugclerk/venv/lib/python3.11/site-packages/github/IssueComment.py", line 160, in create_reaction
    headers, data = self._requester.requestJsonAndCheck(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bugclerk/venv/lib/python3.11/site-packages/github/Requester.py", line 315, in requestJsonAndCheck
    return self.__check(
           ^^^^^^^^^^^^^
  File "/home/bugclerk/venv/lib/python3.11/site-packages/github/Requester.py", line 340, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 403 {"message": "Must have admin rights to Repository.", "documentation_url": "https://docs.github.com/rest/reactions/reactions#create-reaction-for-an-issue-comment"}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants