NAS-125841 / 23.10.1.1 / Gracefully handle case for aggregating disk temperatures when no temperatures have been retrieved (by Qubad786) (by bugclerk) #12826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
skip_zero_values_in_aggregation
flag is set to true in the disktemp graph. As a result, aggregation calculations are skipped if all the disk temperature values are zero. In some cases, temperature values might not exist, causing a key error when retrieving disk temperature from thetemperature_agg
API.Solution
Now, the
temperature_agg
is retrieved safely, and default null values are returned to prevent the key error.Original PR: #12806
Jira URL: https://ixsystems.atlassian.net/browse/NAS-125841
Original PR: #12808
Jira URL: https://ixsystems.atlassian.net/browse/NAS-125841