Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-125841 / 23.10.1.1 / Gracefully handle case for aggregating disk temperatures when no temperatures have been retrieved (by Qubad786) (by bugclerk) #12826

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Jan 2, 2024

Problem

The skip_zero_values_in_aggregation flag is set to true in the disktemp graph. As a result, aggregation calculations are skipped if all the disk temperature values are zero. In some cases, temperature values might not exist, causing a key error when retrieving disk temperature from the temperature_agg API.

Solution

Now, the temperature_agg is retrieved safely, and default null values are returned to prevent the key error.

Original PR: #12806
Jira URL: https://ixsystems.atlassian.net/browse/NAS-125841

Original PR: #12808
Jira URL: https://ixsystems.atlassian.net/browse/NAS-125841

@yocalebo yocalebo merged commit b933fba into release/23.10.1.1 Jan 2, 2024
1 of 2 checks passed
@yocalebo yocalebo deleted the NAS-125841-23.10.1.1 branch January 2, 2024 14:45
@bugclerk
Copy link
Contributor Author

bugclerk commented Jan 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants