Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128506 / 24.10 / Fix test iscsi auth network #13618

Merged
merged 3 commits into from Apr 24, 2024

Conversation

bmeagherix
Copy link
Contributor

@bmeagherix bmeagherix commented Apr 24, 2024

Fix a bunch of tests that are failing in CI

  • When running iscsiadm in tests precede with a sudo if we are not running as root.
  • Improve test_iscsi_auth_network.py in several ways
    • Make my_ip4 a fixture so it only needs to run once
    • Extend my_ip4 so that it can even handle NAT situations (ssh / SSH_CLIENT)
    • flake8 fixes

Also required the ZFS fix in PR #230

@bugclerk bugclerk changed the title Fix test iscsi auth network NAS-128506 / 24.10 / Fix test iscsi auth network Apr 24, 2024
@bugclerk
Copy link
Contributor

@truenas truenas deleted a comment from bugclerk Apr 24, 2024
@bmeagherix bmeagherix requested a review from a team April 24, 2024 16:34
@bmeagherix bmeagherix merged commit dbbd64f into master Apr 24, 2024
2 checks passed
@bmeagherix bmeagherix deleted the fix_test_iscsi_auth_network branch April 24, 2024 18:52
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants