Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129663 / 24.10 / Use SSS to perform SID conversion when enabled #13898

Merged
merged 12 commits into from
Jun 21, 2024

Conversation

anodos325
Copy link
Contributor

IPA domains provide users and groups SIDs for SMB protocol support. When the LDAP service is enabled we should wrap around the python sss nss idmap module to resolve SIDs for cases where we need them.

@anodos325 anodos325 added the jira label Jun 19, 2024
@bugclerk bugclerk changed the title Use SSS to perform SID conversion when enabled NAS-129663 / 24.10 / Use SSS to perform SID conversion when enabled Jun 19, 2024
@bugclerk
Copy link
Contributor

@anodos325 anodos325 force-pushed the use-python-sss-idmap branch 8 times, most recently from 0f0796f to da22e5e Compare June 20, 2024 12:45
IPA domains provide users and groups SIDs for SMB protocol
support. When the LDAP service is enabled we should wrap
around the python sss nss idmap module to resolve SIDs for
cases where we need them.

This commit also extends the output of get_user_obj and
get_group_obj to include explicit information about the source
providing the ID, which helps to streamline authentication.
Copy link
Contributor

@bmeagherix bmeagherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most review items are comments / nice-to-have, but would like more wrt do_unmapped and ae_who_name.

src/middlewared/middlewared/plugins/account.py Outdated Show resolved Hide resolved
src/middlewared/middlewared/plugins/account.py Outdated Show resolved Hide resolved
src/middlewared/middlewared/plugins/account.py Outdated Show resolved Hide resolved
src/middlewared/middlewared/plugins/account.py Outdated Show resolved Hide resolved
src/middlewared/middlewared/plugins/auth_/authenticate.py Outdated Show resolved Hide resolved
src/middlewared/middlewared/plugins/idmap_/idmap_sss.py Outdated Show resolved Hide resolved
@anodos325 anodos325 merged commit e145a1f into master Jun 21, 2024
2 of 3 checks passed
@anodos325 anodos325 deleted the use-python-sss-idmap branch June 21, 2024 18:53
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants