Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tkt-76440: Migrate CA's to Certificate in Directory Services #2692

Merged
merged 2 commits into from
Mar 5, 2019
Merged

tkt-76440: Migrate CA's to Certificate in Directory Services #2692

merged 2 commits into from
Mar 5, 2019

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Mar 1, 2019 •
edited

This PR aims to bring the following changes:

  1. Migrate CA's to Certificates in Directory Services
  2. Remove all CA related usages in Directory Services
  3. Bug fix which for ldap.conf which would result in failure to generate ldap.conf under certain conditions because of an exception raised

Ticket: #76440

@sonicaj
Migration for directory services
fe056d3 
This commit adds a migration to make sure that we use Certificate model instead of CertificateAuthority model in directory services.
Ticket: #76440
@sonicaj
Remove ca usages in directory services
4e53118 
This commit removes all ca usages in directory services.
@sonicaj sonicaj added the WIP label Mar 1, 2019
@sonicaj sonicaj self-assigned this Mar 1, 2019
@bugclerk bugclerk changed the title Migrate CA's to Certificate in Directory Services tkt-76440: Migrate CA's to Certificate in Directory Services Mar 1, 2019
@sonicaj sonicaj added pending QA and removed WIP labels Mar 1, 2019
@sonicaj sonicaj requested a review from william-gr March 1, 2019 12:12
@william-gr william-gr requested review from anodos325 and removed request for william-gr March 1, 2019 12:22
anodos325
anodos325 approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@anodos325 anodos325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonicaj sonicaj merged commit 9c9d0a5 into master Mar 5, 2019
@sonicaj sonicaj deleted the issues/76440 branch March 5, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anodos325 anodos325 anodos325 approved these changes

Assignees

@sonicaj sonicaj

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sonicaj @anodos325