Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-101074 / 11.3 / Block VolumeStatus alert source while creating pool (by themylogin) #2872

Merged
merged 2 commits into from
Apr 12, 2019
Merged

NAS-101074 / 11.3 / Block VolumeStatus alert source while creating pool (by themylogin) #2872

merged 2 commits into from
Apr 12, 2019

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git cherry-pick -x 726ed446a0691682c44ebe3f3cab274f4d0f3737
git cherry-pick -x 076bf3f5206a3384dfb558a34eae58928a6a060c

@themylogin
Copy link
Contributor

@william-gr do I understand correctly that in 11.3 we do 'datastore.insert', 'storage.volume' after ZFS pool is created and that's why there is no such a race condition?

william-gr
william-gr approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@william-gr william-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, there may still be a window for a race condition, but its likely too small we will hardly ever find it

@themylogin themylogin merged commit e6ad331 into master Apr 12, 2019
@themylogin themylogin deleted the NAS-101074-11.3 branch April 12, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-gr william-gr william-gr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bugclerk @themylogin @william-gr