NAS-109824 / 21.04 / Ensure aclmode set to DISCARD if not using NFSv4 ACLs on SCALE #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a discard aclmode ensures that users can "undo" an existing native ZFS ACL through chmod or setfacl. The ZoL POSIX ACL implementation writes the POSIX ACL in an xattr separate from the native ZFS ACL and zfs_acl_chmod_setattr() is used to set POSIX mode during setacl and chmod requests. If aclmode is set to DISCARD, then existing native ZFS ACL is replaced with one equivalent to specified mode. This commit also updates acltype property names to correct, final ones returned by openzfs. Legacy acltypes are left available as options to avoid API changes.
anodos325
force-pushed
the
restrict-aclmode-choices-based-on-acltype
branch
from
d4ba76d
to
7467ac6
Compare
ghost
approved these changes
Mar 16, 2021
bugclerk
changed the title
sonicaj
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a discard aclmode ensures that users can "undo" an existing
native ZFS ACL through chmod or setfacl. The ZoL POSIX ACL implementation
writes the POSIX ACL in an xattr separate from the native ZFS ACL and
zfs_acl_chmod_setattr() is used to set POSIX mode during setacl and chmod
requests. If aclmode is set to DISCARD, then existing native ZFS ACL is
replaced with one equivalent to specified mode.
This commit also updates aclmode property names to correct, final ones
returned by openzfs.