NAS-112721 / 21.10 / Add API call to create directories #7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primary use case is to expose ability to create paths inside cluster volumes for users to share out via SMB or oher protocols.
bugclerk
changed the title
themylogin
reviewed
Oct 7, 2021
| 'gid': stat.st_gid, | ||
| }) | ||
| except FileNotFoundError: | ||
| data.update({'size': None, 'mode': None, 'acl': None, 'uid': None, 'gid': None}) |
There was a problem hiding this comment.
I am a third party here, who knows nothing about cluster, but what does this mean, haven't we just created this path?
There was a problem hiding this comment.
It means that I copy-pasted some things without thinking.
themylogin
requested changes
Oct 7, 2021
| 'type': 'DIRECTORY', | ||
| } | ||
|
|
||
| stat = p.stat() |
There was a problem hiding this comment.
You can move this call just below mkdir and have data in a single dictionary declaration
| Int('mode', required=True, null=True), | ||
| Bool('acl', required=True, null=True), | ||
| Int('uid', required=True, null=True), | ||
| Int('gid', required=True, null=True), |
There was a problem hiding this comment.
Why null=True, can these be null?
There was a problem hiding this comment.
Copy-paste. I'll just change to Ref the path_entry from filesystem.listdir, which was the intention to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary use case is to expose ability to create paths inside
cluster volumes for users to share out via SMB or other
file sharing protocols.
Return value is same as entry from filesystem.listdir.