Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-114945 / 22.02.1 / Expand warning for shell modifications #8322

Merged
merged 4 commits into from Feb 21, 2022
Merged

NAS-114945 / 22.02.1 / Expand warning for shell modifications #8322

merged 4 commits into from Feb 21, 2022

Conversation

anodos325
Copy link
Contributor

"CLI" is now ambiguous because it refers to the TrueNAS CLI (which
is a supported way of making changes).

@anodos325 anodos325 requested review from a team and Mrt134 February 21, 2022 14:42
@anodos325 anodos325 added the jira label Feb 21, 2022
@bugclerk
Copy link
Contributor

Jira URL: https://jira.ixsystems.com/browse/NAS-114945

@bugclerk bugclerk changed the title Expand warning for shell modifications NAS-114945 / 22.02.1 / Expand warning for shell modifications Feb 21, 2022
@anodos325
Expand warning for shell modifications
815fe14 
"CLI" is now ambiguous because it refers to the TrueNAS CLI (which
is a supported way of making changes).
@yocalebo
Copy link
Contributor

retest this please

ericloewe
ericloewe reviewed Feb 21, 2022
View reviewed changes
src/freenas/root/.warning Outdated
supported and may result in breaking the TrueNAS appliance.
Warning: the supported mechanisms for making configuration changes
are the TrueNAS WebUI, CLI, and API exclusively. ALL OTHERS ARE
NOT SUPPORTED AND WILL RESULT IN UNEXPECTED BEHAVIOR AND MAY
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm partial to "undefined" behavior instead of "unexpected".

@anodos325 anodos325 merged commit 506c214 into master Feb 21, 2022
@anodos325 anodos325 deleted the make-better-warning branch February 21, 2022 19:24
This was referenced Feb 21, 2022
Merged
Closed
@stephendt
Copy link

stephendt commented Feb 22, 2022 •
edited

Should probably specifically mention that the usage of package managers for updates is likely to break their system, just in case someone wants to configure automatic updates via Cron or something.

@anodos325
Copy link
Contributor Author

Should probably specifically mention that the usage of package managers for updates is likely to break their system, just in case someone wants to configure automatic updates via Cron or something.

Currently, we are protected from this by having apt-related binaries being non-executable (balancing act between allowing people to make informed decisions and helping avoid foot-shooting). We could probably make same with package management tools in Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themylogin themylogin themylogin left review comments

@ericloewe ericloewe ericloewe left review comments

@yocalebo yocalebo yocalebo approved these changes

@Mrt134 Mrt134 Awaiting requested review from Mrt134

Assignees
No one assigned
Labels
backported jira
Projects
None yet
Milestone
No milestone
6 participants
@anodos325 @bugclerk @yocalebo @stephendt @themylogin @ericloewe