Minor typo in NvmeAttributes() fixes #81

truenas · Feb 16, 2024 · fbe13ae · fbe13ae
1 parent faea21d
commit fbe13ae
Show file tree

Hide file tree

Showing 16 changed files with 2 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 Version 1.3.1
 =============
 - Added support for test polling_minutes. Requested in [#77](https://github.com/truenas/py-SMART/issues/77) and [#78](https://github.com/truenas/py-SMART/pull/78). Thanks @Gigahawk
+- Minnor typo fixed in NvmeAttributes (issue [#81](https://github.com/truenas/py-SMART/issues/81)).  Thanks @petersulyok
 - **Breaking changes**
     - **smartctl.all**:
         - Officially removed support for python 3.7.

diff --git a/pySMART/interface/nvme/__init__.py b/pySMART/interface/nvme/__init__.py
@@ -533,7 +533,7 @@ def __init__(self, data: Optional[Iterator[str]] = None):
 
         """
 
-        self.critialWarning: Optional[int] = None
+        self.criticalWarning: Optional[int] = None
         self._temperature: Optional[int] = None
         self.availableSpare: Optional[int] = None
         self.availableSpareThreshold: Optional[int] = None

diff --git a/tests/dataset/singletests/nvme_0/device.json b/tests/dataset/singletests/nvme_0/device.json
@@ -323,7 +323,6 @@
             "bytesRead": 15000000000000,
             "bytesWritten": 12600000000000,
             "controllerBusyTime": 8134,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 29426647,

diff --git a/tests/dataset/singletests/nvme_10_issue_73/device.json b/tests/dataset/singletests/nvme_10_issue_73/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 2470000000000,
             "bytesWritten": 2530000000000,
             "controllerBusyTime": 5,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 4830606,

diff --git a/tests/dataset/singletests/nvme_11_issue_75/device.json b/tests/dataset/singletests/nvme_11_issue_75/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 18100000000000,
             "bytesWritten": 21400000000000,
             "controllerBusyTime": 16624,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 35495552,

diff --git a/tests/dataset/singletests/nvme_1_issue_37/device.json b/tests/dataset/singletests/nvme_1_issue_37/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 303000000000,
             "bytesWritten": 1000000000000,
             "controllerBusyTime": 18,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 593252,

diff --git a/tests/dataset/singletests/nvme_2_issue_46/device.json b/tests/dataset/singletests/nvme_2_issue_46/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 32600000000000,
             "bytesWritten": 7180000000000,
             "controllerBusyTime": 1670,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 63787598,

diff --git a/tests/dataset/singletests/nvme_3_issue_52/device.json b/tests/dataset/singletests/nvme_3_issue_52/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 341000000000,
             "bytesWritten": 436000000000,
             "controllerBusyTime": 83,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 667420,

diff --git a/tests/dataset/singletests/nvme_4_issue_53/device.json b/tests/dataset/singletests/nvme_4_issue_53/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 41900000000000,
             "bytesWritten": 29000000000000,
             "controllerBusyTime": 567,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 81966502,

diff --git a/tests/dataset/singletests/nvme_5_issue_46/device.json b/tests/dataset/singletests/nvme_5_issue_46/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 830000000000,
             "bytesWritten": 1950000000000,
             "controllerBusyTime": 39,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 1622460,

diff --git a/tests/dataset/singletests/nvme_6/device.json b/tests/dataset/singletests/nvme_6/device.json
@@ -323,7 +323,6 @@
             "bytesRead": 17300000000000,
             "bytesWritten": 18700000000000,
             "controllerBusyTime": 14050,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 33835011,

diff --git a/tests/dataset/singletests/nvme_7_issue_63/device.json b/tests/dataset/singletests/nvme_7_issue_63/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 12600000000000,
             "bytesWritten": 9970000000000,
             "controllerBusyTime": 403,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 24646582,

diff --git a/tests/dataset/singletests/nvme_8/device.json b/tests/dataset/singletests/nvme_8/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 0,
             "bytesWritten": 0,
             "controllerBusyTime": 403,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 0,

diff --git a/tests/dataset/singletests/nvme_9_issue_72/device.json b/tests/dataset/singletests/nvme_9_issue_72/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 11000000000000,
             "bytesWritten": 8279999999999,
             "controllerBusyTime": 5077,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 21600976,

diff --git a/tests/dataset/singletests/nvme_win10_0_issue_64/device.json b/tests/dataset/singletests/nvme_win10_0_issue_64/device.json
@@ -324,7 +324,6 @@
             "bytesRead": 77400000000000,
             "bytesWritten": 135000000000000,
             "controllerBusyTime": 19134,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 151288508,

diff --git a/tests/dataset/singletests/nvme_win10_mingw32_0_issue_48/device.json b/tests/dataset/singletests/nvme_win10_mingw32_0_issue_48/device.json
@@ -323,7 +323,6 @@
             "bytesRead": 10100000000000,
             "bytesWritten": 12400000000000,
             "controllerBusyTime": 496,
-            "critialWarning": null,
             "criticalTemperatureTime": 0,
             "criticalWarning": 0,
             "dataUnitsRead": 19767201,