Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128169 / 24.10 / Implement main logic in DashboardStore #10009

Merged
merged 4 commits into from May 1, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket

Now we load widgets from user.attributes.dashState, if some of the widgets is not using updated structure - we update it to be a full WidgetGroupLayout.Full widget. (check getDashboardGroups logic in dashboard.store.ts)

As well we can reorder widgets and save the state.

NAS-128169.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Apr 30, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner April 30, 2024 06:50
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team April 30, 2024 06:50
@bugclerk bugclerk changed the title NAS-128169: Implement main logic in DashboardStore NAS-128169 / 24.10 / Implement main logic in DashboardStore Apr 30, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 70.31250% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 73.49%. Comparing base (7b2e738) to head (adb37e8).
Report is 3 commits behind head on master.

Files Patch % Lines
...rc/app/pages/dashboard/services/dashboard.store.ts 65.45% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10009      +/-   ##
==========================================
+ Coverage   73.44%   73.49%   +0.05%     
==========================================
  Files        1499     1501       +2     
  Lines       52599    52689      +90     
  Branches     6278     6296      +18     
==========================================
+ Hits        38632    38726      +94     
+ Misses      13967    13963       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works as expected

@AlexKarpov98 AlexKarpov98 merged commit ad58f09 into master May 1, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128169 branch May 1, 2024 06:06
@bugclerk
Copy link
Contributor

bugclerk commented May 1, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants