NAS-128844 / 24.10 / Use new icon to represent datasets

[denysbutenko]

Visit the Datasets page to see the changes. The original icon was renamed dataset_root, and a new dataset icon was added.

Demo:

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128844

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (9c605a3) to head (c36b2b6).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10058      +/-   ##
==========================================
+ Coverage   73.80%   73.85%   +0.04%     
==========================================
  Files        1522     1520       -2     
  Lines       53252    53202      -50     
  Branches     6357     6352       -5     
==========================================
- Hits        39304    39290      -14     
+ Misses      13948    13912      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[undsoft]

1. It's too large. It should be roughly the same size as zvol or dataset_root icon.
2. It should be updated in ix-explorer.

[bvasilenko]

Looks good!
New icon is displayed where it's expected to display

[denysbutenko]

1. It's too large. It should be roughly the same size as zvol or dataset_root icon.

Okay done

2. It should be updated in ix-explorer.

ix-explorer uses three folder icons: folder, folder_open, and mdi-folder-lock. I've replaced folder icon for now.

[denysbutenko]

Looking into reasons for test failing.

[undsoft]

New icon looks good.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.