Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-128970 / 24.10 / TrueCloud Backup defaults to /mnt selected #10061

Merged
merged 2 commits into from
May 14, 2024
Merged

NAS-128970 / 24.10 / TrueCloud Backup defaults to /mnt selected #10061

merged 2 commits into from
May 14, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket
Screenshot 2024-05-14 at 11 39 53

@AlexKarpov98 AlexKarpov98 self-assigned this May 14, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 14, 2024 08:40
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team May 14, 2024 08:40
@bugclerk bugclerk changed the title NAS-128970: TrueCloud Backup defaults to /mnt selected NAS-128970 / 24.10 / TrueCloud Backup defaults to /mnt selected May 14, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128970

undsoft
undsoft approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No default value is set.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) May 14, 2024 09:46
@codecov Codecov
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.86%. Comparing base (b918e55) to head (08f6ff4).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10061      +/-   ##
==========================================
- Coverage   73.86%   73.86%   -0.01%     
==========================================
  Files        1520     1520              
  Lines       53202    53200       -2     
  Branches     6352     6352              
==========================================
- Hits        39296    39294       -2     
  Misses      13906    13906

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 2552f15 into master May 14, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128970 branch May 14, 2024 10:27
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

@bvasilenko bvasilenko Awaiting requested review from bvasilenko bvasilenko is a code owner automatically assigned from truenas/ui-team

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
3 participants
@AlexKarpov98 @bugclerk @undsoft