NAS-128457 / 24.10 / Reorganizing enclosure pages #10064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undsoft
requested review from
AlexKarpov98,
RehanY147 and
a team
and removed request for
a team
bugclerk
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10064 +/- ##
==========================================
+ Coverage 73.84% 73.88% +0.03%
==========================================
Files 1526 1529 +3
Lines 53428 53484 +56
Branches 6387 6390 +3
==========================================
+ Hits 39452 39514 +62
+ Misses 13976 13970 -6 ☔ View full report in Codecov by Sentry. |
RehanY147
requested changes
May 15, 2024
| ] as const; | ||
|
|
||
| return supportedViews | ||
| .filter((view) => this.enclosure().elements[view]) |
There was a problem hiding this comment.
Should declare a constant at the start and save the value and reuse it so it's clear this is a dependency for the computed signal.
| component: EnclosureViewComponent, | ||
| data: { title: T('View Enclosure'), breadcrumb: null }, | ||
| }, | ||
| { |
RehanY147
approved these changes
May 15, 2024
|
Doesn't seem like there is an easy solution to item highlighting in the menu. |
# Conflicts: # src/assets/i18n/fr.json # src/assets/i18n/nl.json # src/assets/i18n/zh-hans.json
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes enclosure pages using router into different views, which can be seen by clicking in Elements menu.