Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-128977 / 24.10 / TrueCloud | After new Provider is created no Bucket & Folder is available #10065

Merged
merged 8 commits into from
May 16, 2024
Merged

NAS-128977 / 24.10 / TrueCloud | After new Provider is created no Bucket & Folder is available #10065

merged 8 commits into from
May 16, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket

@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 15, 2024 08:20
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team May 15, 2024 08:20
@bugclerk bugclerk changed the title NAS-128977: TrueCloud | After new Provider is created no Bucket & Folder is available NAS-128977 / 24.10 / TrueCloud | After new Provider is created no Bucket & Folder is available May 15, 2024
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128977

@AlexKarpov98 AlexKarpov98 self-assigned this May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (2525930) to head (1ba8b24).

Files Patch % Lines
...p/cloud-backup-form/cloud-backup-form.component.ts 88.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #10065   +/-   ##
=======================================
  Coverage   73.84%   73.85%           
=======================================
  Files        1526     1526           
  Lines       53447    53447           
  Branches     6388     6387    -1     
=======================================
+ Hits        39468    39471    +3     
+ Misses      13979    13976    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bvasilenko
bvasilenko approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now!

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) May 16, 2024 06:17
@AlexKarpov98 AlexKarpov98 merged commit d56039b into master May 16, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128977 branch May 16, 2024 06:50
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bvasilenko bvasilenko bvasilenko approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
3 participants
@AlexKarpov98 @bugclerk @bvasilenko