Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128976 / 24.10 / TrueCloud | Bucket is not populated on Edit & selected bucket is not sent to middleware #10066

Merged
merged 6 commits into from
May 15, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket

@AlexKarpov98 AlexKarpov98 self-assigned this May 15, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 15, 2024 08:20
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team May 15, 2024 08:20
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-128976: TrueCloud | Bucket is not populated on Edit & selected bucket is not sent to middleware NAS-128976 / 24.10 / TrueCloud | Bucket is not populated on Edit & selected bucket is not sent to middleware May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.84%. Comparing base (3033c4e) to head (e59b7c6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10066   +/-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files        1526     1526           
  Lines       53446    53447    +1     
  Branches     6387     6388    +1     
=======================================
+ Hits        39467    39468    +1     
  Misses      13979    13979           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@AlexKarpov98
Copy link
Contributor Author

@undsoft
Screenshot 2024-05-15 at 17 43 48

@AlexKarpov98 AlexKarpov98 requested a review from undsoft May 15, 2024 14:43
@undsoft
Copy link
Collaborator

undsoft commented May 15, 2024

See if the issue gets resolved if you pull master to get Denyses package.json fix.

@AlexKarpov98 AlexKarpov98 removed the request for review from undsoft May 15, 2024 15:20
@AlexKarpov98 AlexKarpov98 merged commit 2525930 into master May 15, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128976 branch May 15, 2024 21:07
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants