Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129015 / 24.10 / Edit scenario on main dashboard #10068

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented May 15, 2024

  • Fixes edit scenario on main dashboard.
  • Updates layout selector to keep order of items.
  • Reworks tests for ix-icon-group.

@undsoft undsoft requested a review from a team as a code owner May 15, 2024 17:04
@undsoft undsoft requested review from denysbutenko and removed request for a team May 15, 2024 17:04
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-129015: Edit scenario on main dashboard NAS-129015 / 24.10 / Edit scenario on main dashboard May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.86%. Comparing base (3033c4e) to head (903c8ef).
Report is 7 commits behind head on master.

Files Patch % Lines
...hboard/components/dashboard/dashboard.component.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10068      +/-   ##
==========================================
+ Coverage   73.84%   73.86%   +0.02%     
==========================================
  Files        1526     1527       +1     
  Lines       53446    53453       +7     
  Branches     6387     6391       +4     
==========================================
+ Hits        39467    39485      +18     
+ Misses      13979    13968      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notification toast Dashboard settings saved on Save action compared to old dashboard. Other than that it looks good.

@undsoft undsoft enabled auto-merge (squash) May 17, 2024 07:01
@undsoft undsoft merged commit f9830f2 into master May 17, 2024
10 checks passed
@undsoft undsoft deleted the NAS-129015 branch May 17, 2024 07:33
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants