Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128980 / 24.10 / TrueCloud | Not all possible fields are shown to the user on the form and on the details card #10071

Merged
merged 3 commits into from
May 16, 2024

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented May 16, 2024

Testing: see ticket & more fields to be available for the user

Before:
Screenshot 2024-05-16 at 12 38 58

After:
Screenshot 2024-05-16 at 12 39 20

Before:
Screenshot 2024-05-16 at 12 39 09

After:
Screenshot 2024-05-16 at 12 39 32

@AlexKarpov98 AlexKarpov98 self-assigned this May 16, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner May 16, 2024 09:44
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team May 16, 2024 09:44
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-128980: TrueCloud | Not all possible fields are shown to the user on the form and on the details card NAS-128980 / 24.10 / TrueCloud | Not all possible fields are shown to the user on the form and on the details card May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.84%. Comparing base (d56039b) to head (aa9ad64).

Files Patch % Lines
...p/cloud-backup-form/cloud-backup-form.component.ts 66.66% 3 Missing ⚠️
src/app/services/cloud-credential.service.ts 86.66% 2 Missing ⚠️
...oud-backup-restore-from-snapshot-form.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10071      +/-   ##
==========================================
- Coverage   73.85%   73.84%   -0.01%     
==========================================
  Files        1526     1526              
  Lines       53447    53436      -11     
  Branches     6387     6387              
==========================================
- Hits        39471    39459      -12     
- Misses      13976    13977       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good 👍🏻

@AlexKarpov98 AlexKarpov98 merged commit 1b10715 into master May 16, 2024
10 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-128980 branch May 16, 2024 11:32
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants