Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128973 / 24.10 / Add force flag boolean to jbof.delete call #10072

Closed
wants to merge 3 commits into from

Conversation

RehanY147
Copy link
Contributor

Also test for regressions in deleting certificates and CSR's. And check for the force flag in the jbof delete call.
This PR creates a new dialog for confirming delete with an optional force flag.

@RehanY147 RehanY147 requested a review from a team as a code owner May 16, 2024 10:32
@RehanY147 RehanY147 requested review from AlexKarpov98 and removed request for a team May 16, 2024 10:32
@bugclerk bugclerk changed the title Add force flag boolean to jbof.delete call NAS-128973 / 24.10 / Add force flag boolean to jbof.delete call May 16, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.85%. Comparing base (d56039b) to head (e75f530).

Files Patch % Lines
src/app/modules/dialog/dialog.service.ts 33.33% 2 Missing ⚠️
...te-dialog/confirm-force-delete-dialog.component.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10072   +/-   ##
=======================================
  Coverage   73.85%   73.85%           
=======================================
  Files        1526     1526           
  Lines       53447    53462   +15     
  Branches     6387     6388    +1     
=======================================
+ Hits        39471    39483   +12     
- Misses      13976    13979    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good 👍
Screenshot 2024-05-17 at 08 39 20

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I started looking at the code and noticed that ConfirmDialogComponent already has a lot of similar functionality that we may have reimplemented :)

@RehanY147 RehanY147 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants