Skip to content

Commit

Permalink
vdev_disk: don't touch vbio after its handed off to the kernel
Browse files Browse the repository at this point in the history
After IO is unplugged, it may complete immediately and vbio_completion
be called on interrupt context. That may interrupt or deschedule our
task. If its the last bio, the vbio will be freed. Then, we get
rescheduled, and try to write to freed memory through vbio->.

This patch just removes the the cleanup, and the corresponding assert.
These were leftovers from a previous iteration of vbio_submit() and were
always "belt and suspenders" ops anyway, never strictly required.

Reported-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
  • Loading branch information
robn authored and ixhamza committed Apr 2, 2024
1 parent 77f0e6d commit 774da47
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions module/os/linux/zfs/vdev_disk.c
Original file line number Diff line number Diff line change
Expand Up @@ -758,8 +758,6 @@ vbio_fill_cb(struct page *page, size_t off, size_t len, void *priv)
static void
vbio_submit(vbio_t *vbio, abd_t *abd, uint64_t size)
{
ASSERT(vbio->vbio_bdev);

/*
* We plug so we can submit the BIOs as we go and only unplug them when
* they are fully created and submitted. This is important; if we don't
Expand All @@ -780,9 +778,6 @@ vbio_submit(vbio_t *vbio, abd_t *abd, uint64_t size)
vdev_submit_bio(vbio->vbio_bio);

blk_finish_plug(&plug);

vbio->vbio_bio = NULL;
vbio->vbio_bdev = NULL;
}

/* IO completion callback */
Expand Down

0 comments on commit 774da47

Please sign in to comment.