Skip to content

Commit

Permalink
Add a test case for zfs import with missing log device
Browse files Browse the repository at this point in the history
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
  • Loading branch information
ixhamza committed May 3, 2023
1 parent fe26d0c commit 87a4515
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 1 deletion.
2 changes: 1 addition & 1 deletion tests/runfiles/common.run
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ tests = ['zpool_import_001_pos', 'zpool_import_002_pos',
'import_cachefile_mirror_detached',
'import_cachefile_paths_changed',
'import_cachefile_shared_device',
'import_devices_missing',
'import_devices_missing', 'import_log_missing',
'import_paths_changed',
'import_rewind_config_changed',
'import_rewind_device_replaced']
Expand Down
1 change: 1 addition & 0 deletions tests/zfs-tests/tests/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,7 @@ nobase_dist_datadir_zfs_tests_tests_SCRIPTS += \
functional/cli_root/zpool_import/import_cachefile_paths_changed.ksh \
functional/cli_root/zpool_import/import_cachefile_shared_device.ksh \
functional/cli_root/zpool_import/import_devices_missing.ksh \
functional/cli_root/zpool_import/import_log_missing.ksh \
functional/cli_root/zpool_import/import_paths_changed.ksh \
functional/cli_root/zpool_import/import_rewind_config_changed.ksh \
functional/cli_root/zpool_import/import_rewind_device_replaced.ksh \
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
#!/bin/ksh -p

#
# This file and its contents are supplied under the terms of the
# Common Development and Distribution License ("CDDL"), version 1.0.
# You may only use this file in accordance with the terms of version
# 1.0 of the CDDL.
#
# A full copy of the text of the CDDL should have accompanied this
# source. A copy of the CDDL is also available via the Internet at
# http://www.illumos.org/license/CDDL.
#

. $STF_SUITE/tests/functional/cli_root/zpool_import/zpool_import.kshlib

#
# DESCRIPTION:
# Import with missing log device should not remove spare/cache.
#
# STRATEGY:
# 1. Create a pool.
# 2. Add spare, cache and log devices to the pool.
# 3. Export the pool.
# 4. Remove the log device.
# 5. Import the pool with -m flag.
# 6. Verify that spare and cache are still present in the pool.
#

verify_runnable "global"

log_onexit cleanup

function test_missing_log
{
typeset poolcreate="$1"
typeset cachevdev="$2"
typeset sparevdev="$3"
typeset logvdev="$4"
typeset missingvdev="$4"

log_note "$0: pool '$poolcreate', adding $cachevdev, $sparevdev," \
"$logvdev then moving away $missingvdev."

log_must zpool create $TESTPOOL1 $poolcreate

log_must zpool add $TESTPOOL1 cache $cachevdev spare $sparevdev \
log $logvdev

log_must_busy zpool export $TESTPOOL1

log_must mv $missingvdev $BACKUP_DEVICE_DIR

log_must zpool import -m -d $DEVICE_DIR $TESTPOOL1

CACHE_PRESENT=$(zpool status -v $TESTPOOL1 | grep $cachevdev)

SPARE_PRESENT=$(zpool status -v $TESTPOOL1 | grep $sparevdev)

if [ -z "$CACHE_PRESENT"] || [ -z "SPARE_PRESENT"]
then
log_fail "cache/spare vdev missing after importing with missing" \
"log device"
fi

# Cleanup
log_must zpool destroy $TESTPOOL1

log_note ""
}

log_must mkdir -p $BACKUP_DEVICE_DIR

test_missing_log "$VDEV0" "$VDEV1" "$VDEV2" "$VDEV3"

log_pass "zpool import succeeded with missing log device"

0 comments on commit 87a4515

Please sign in to comment.