Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify linux headers dependencies in control file #134

Merged
merged 1 commit into from
May 10, 2023

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented May 10, 2023

No description provided.

@sonicaj sonicaj self-assigned this May 10, 2023
@sonicaj sonicaj merged commit 75f7e39 into truenas/zfs-2.1-release May 10, 2023
@sonicaj sonicaj deleted the NAS-121888 branch May 10, 2023 11:06
@ixhamza
Copy link

ixhamza commented May 10, 2023

It seems that this PR is causing the CI pipeline to fail.

@sonicaj
Copy link
Member Author

sonicaj commented May 10, 2023

@ixhamza that is probably because these packages are not available when you build the debian package in github CI but when you actually build openzfs in our environment, these are required afaik as openzfs was marked as being a kernel module which basically means it needs these packages to build.
The proper fix is to have these dependencies specified in the package's control file and not do them in the builder, earlier it was done for a different reason which is no longer valid. I think we should probably update the CI to either pull the debian packages from somewhere ( we would need to host these ) or maybe do some magic in the CI to remove these deps and then build and test with standard linux image headers ?

@usaleem-ix
Copy link

How about updating the control file from prebuildcmd for openzfs and openzfs-dbg in build.manifest from scale-build?

I think that would be a better approach. We can keep this repo and CI clean, and building and installing OpenZFS packages would not require installing TrueNAS Linux kernels and headers. We already update debian/control.modules.in for openzfs-dbg in build.manifest.

@sonicaj
Copy link
Member Author

sonicaj commented May 10, 2023

As long as these get added in build and install time dependencies in openzfs control file (whether here or in scale build), i am fine with it. @usaleem-ix can you do the honours please ?

@usaleem-ix
Copy link

Sure, I will create a ticket for it and assign to myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants