Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated App.select_context to support MultiQueryRetriever of langchain #1014

Merged
merged 11 commits into from
Mar 22, 2024

Conversation

sayedsohan
Copy link
Contributor

Added App.select_context to support MultiQueryRetriever of langchain.

Added App.select_context to support MultiQueryRetriever of langchain.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 19, 2024
@joshreini1
Copy link
Contributor

Thanks @sayedsohan - can you add an example notebook?

@sayedsohan
Copy link
Contributor Author

sayedsohan commented Mar 19, 2024

Hi, @joshreini1 Here is the https://drive.google.com/file/d/1BaTtrX1r77Ha7Bk8MonoImhcOgMwG8tN/view?usp=sharing notebook where I generated the issue with multiQueryRetrieval for the current version of trulens. Please check

joshreini1 and others added 2 commits March 19, 2024 15:17
Added experimental example for MultiQueryRetrieval of langchain.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 20, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sayedsohan
Copy link
Contributor Author

Initially, I didn't notice the example notebook folder and shared gdrive link. I have added and commited the notebook in trulens_eval/examples/experimental/MultiQueryRetrievalLangchain.ipynb for future references and community help.

@joshreini1
Copy link
Contributor

joshreini1 commented Mar 20, 2024

Thanks @sayedsohan - for the notebook, please clear the output and add some markdown to describe its purpose.

It'd be great also if you can show the full trulens flow including the creation of a recorder and feedback functions that use the context you're enabling.

@sayedsohan
Copy link
Contributor Author

Hi, @joshreini1 I have updated the notebook with some details and markdown. Also removed the cell output and added trulens recorder with feedback functions.

@joshreini1
Copy link
Contributor

joshreini1 commented Mar 21, 2024

Thanks @sayedsohan - notebook looks great. Will give it a try later

@joshreini1 joshreini1 self-requested a review March 22, 2024 21:04
Copy link
Contributor

@joshreini1 joshreini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future it'd be great to improve further so that the intermediate queries are captured and evaluated on their own merit rather than in one monolith.

Regardless - this is still net positive so no reason to block on that.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 22, 2024
@joshreini1 joshreini1 merged commit cae1e2f into truera:main Mar 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants