-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated App.select_context to support MultiQueryRetriever of langchain #1014
Conversation
Added App.select_context to support MultiQueryRetriever of langchain.
Thanks @sayedsohan - can you add an example notebook? |
Hi, @joshreini1 Here is the https://drive.google.com/file/d/1BaTtrX1r77Ha7Bk8MonoImhcOgMwG8tN/view?usp=sharing notebook where I generated the issue with multiQueryRetrieval for the current version of trulens. Please check |
Added experimental example for MultiQueryRetrieval of langchain.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Initially, I didn't notice the example notebook folder and shared gdrive link. I have added and commited the notebook in trulens_eval/examples/experimental/MultiQueryRetrievalLangchain.ipynb for future references and community help. |
Thanks @sayedsohan - for the notebook, please clear the output and add some markdown to describe its purpose. It'd be great also if you can show the full trulens flow including the creation of a recorder and feedback functions that use the context you're enabling. |
Hi, @joshreini1 I have updated the notebook with some details and markdown. Also removed the cell output and added trulens recorder with feedback functions. |
Thanks @sayedsohan - notebook looks great. Will give it a try later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future it'd be great to improve further so that the intermediate queries are captured and evaluated on their own merit rather than in one monolith.
Regardless - this is still net positive so no reason to block on that.
Added App.select_context to support MultiQueryRetriever of langchain.