Feedback upgrades #1018
Merged
Feedback upgrades #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
the
size:XXL
piotrm0
reviewed
Mar 21, 2024
| return groundedness_scores, {"reasons": reason} | ||
| hypotheses = sent_tokenize(statement) | ||
| reasons_str = "" | ||
| for i, hypothesis in enumerate(tqdm( |
There was a problem hiding this comment.
tqdm is here for debugging? If so, remove?
There was a problem hiding this comment.
tqdm is here to show the progress bar for feedback generation - we have this for the nli method already.
There was a problem hiding this comment.
Better to not have it for either? I don't have a strong opinion
piotrm0
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split system and user prompt:
Enable Mistral models on Bedrock
Enable Meta models on Bedrock
Groundedness improvements (tokenizer splitting for llm-based method, add progress bar in notebook, better spacing of reason in ui)
Show usage of Together AI (LiteLLM Quickstart)
Show usage of Claude-3 (New Claude-3 Quickstart)