Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import improvements, fix version conflicts #1047

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Import improvements, fix version conflicts #1047

merged 12 commits into from
Apr 3, 2024

Conversation

joshreini1
Copy link
Contributor

@joshreini1 joshreini1 commented Apr 2, 2024 •
edited

Other details that are good to know but need not be announced:

  • Fix langchain internal version conflicts on TruLens imports by pinning version of packaging and bumping langchain version
  • Change optional package warnings to DEBUG
  • Make nltk required (needed for groundedness)
  • Download required punkt on Groundedness init

@joshreini1 joshreini1 requested a review from piotrm0 April 2, 2024 23:56
@joshreini1 joshreini1 marked this pull request as ready for review April 3, 2024 00:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Apr 3, 2024
@joshreini1 joshreini1 requested a review from arn-tru April 3, 2024 00:24
@joshreini1 joshreini1 changed the title Fix import version conflicts Import improvements, fix version conflicts Apr 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2024
@joshreini1 joshreini1 merged commit 99a80e0 into main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arn-tru arn-tru arn-tru approved these changes

@piotrm0 piotrm0 Awaiting requested review from piotrm0

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshreini1 @arn-tru