Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import and favicon #1049

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Fix import and favicon #1049

merged 3 commits into from
Apr 3, 2024

Conversation

arn-tru
Copy link
Contributor

@arn-tru arn-tru commented Apr 3, 2024

  • Added psutil to imports (As it was giving "module missing" error on a fresh environment)
  • Added favicon to the streamlit app
  • Refactored add_logo_and_style_overrides() function to handle page config in a common function

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Apr 3, 2024
@arn-tru arn-tru requested a review from joshreini1 April 3, 2024 13:14
joshreini1
joshreini1 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@joshreini1 joshreini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff :) Thanks @arn-tru !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 3, 2024
@joshreini1 joshreini1 merged commit 3da61a0 into main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshreini1 joshreini1 joshreini1 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arn-tru @joshreini1