-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better selection of main input/output #938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Feb 26, 2024
piotrm0
reviewed
Feb 27, 2024
trulens_eval/trulens_eval/app.py
Outdated
@@ -731,7 +749,7 @@ def main_input( | |||
callable_name(func), all_args | |||
) | |||
|
|||
return None | |||
return "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this can fallback to just returning str(all_args) maybe with a prefix "Could not determine main input/output of {str(all_args)}." ?
piotrm0
reviewed
Feb 27, 2024
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Feb 27, 2024
piotrm0
approved these changes
Feb 28, 2024
piotrm0
reviewed
Feb 28, 2024
print -> logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change better extracts the content from main_input and main_output to both display in the TruLens UI and use for helper methods such as
.on_input()
and.on_output()
. Particularly, this change looks for content following the OpenAI pattern, e.g.Inputs such as:
And outputs such as:
Notice in both cases, the text we actually care about is located as the value for the key,
content
. This pattern is widely used and adopted by frameworks such as Pinecone'sCanopy
and middleware such asLiteLLM
.See an example of this change below:
Example 1: Pinecone Canopy
Before:
This warning in notebook:
And
After:
Example 2: OpenAI
Before:
After: