Fix release test pipeline #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on聽 See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
馃憤 Looks good to me!
- Reviewed the entire pull request up to f816c40
- Looked at
10lines of code in1files - Took 39 seconds to review
More info
- Skipped
4files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. docs/trulens_eval/getting_started/quickstarts/index.md:15:
- Assessed confidence :
50% - Comment:
Please ensure that thetrulens_eval/prototype_evals.ipynbnotebook exists and is relevant to this section. - Reasoning:
The PR author has added a new notebook to the list of quickstart notebooks. I need to check if this notebook actually exists in the codebase and if it's relevant to the section.
Workflow ID: wflow_nZFvTULESFIruDQw
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
piotrm0
approved these changes
Mar 6, 2024
dosubot
bot
added
lgtm
There was a problem hiding this comment.
馃憤 Looks good to me!
- Performed an incremental review on e9f3212
- Looked at
2084lines of code in5files - Took 3 minutes and 31 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_MxzQwOa7w3eA9fk5
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
joshreini1
force-pushed
the
josh/test_fixes
branch
from
e9f3212
to
f816c40
Compare
dosubot
bot
added
size:M
joshreini1
force-pushed
the
josh/test_fixes
branch
from
287886a
to
75f2f87
Compare
dosubot
bot
removed
the
size:M
dosubot
bot
added
the
size:XXL
There was a problem hiding this comment.
馃憤 Looks good to me!
- Performed an incremental review on 75f2f87
- Looked at
1407lines of code in1files - Took 2 minutes and 33 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. trulens_eval/generated_files/all_tools.py:1:
- Assessed confidence :
100% - Grade:
0% - Comment:
Consider splitting this script into multiple scripts for better maintainability and readability. Also, avoid hard-coding API keys in the code. Use a secure method to store and access API keys. - Reasoning:
The script is very long and contains multiple sections. It would be better to split it into multiple scripts for better maintainability and readability. Also, the script contains hard-coded API keys which is a security issue. API keys should be stored securely and not exposed in the code.
Workflow ID: wflow_MfZ44SFqxvt0j2yI
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the
index.mdfile, adds a newall_tools.pyfile with quickstart guides, removes several Python scripts, and adds a new quickstart notebook toindex.md.Key points:
index.mdto include new quickstart notebooks.all_tools.pyundertrulens_eval/generated_files/with quickstart guides for TruLens library.trulens_eval/examples/quickstart/py_script_quickstarts/.trulens_eval/prototype_evals.ipynbtoindex.md.Generated with 鉂わ笍 by ellipsis.dev