-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow VirtualRecords to have multiple calls to the same component. #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Mar 11, 2024
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I think we're going for something slightly different in that the repeated call may not be directly in sequence:
|
…le_calls_to_same_path
…iple_calls_to_same_path' into piotrm/virtual_mutliple_calls_to_same_path
joshreini1
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow VirtualRecords to have multiple calls to the same component.
Added updates to the virtual_example with how that is done:
Followed by feedback function variants for this:
combinations
field toFeedback
and argument toFeedback.aggregate
to specify how to build argument dictionaries for feedback functions if selectors generate more than one thing. The default and existing mode is "product" but also added "zip" as an option as specified here:Added FeedbackStatus.SKIPPED to indicate that an eval was skipped and should not be ran again. Fixed runner to take this into account.
Fixed OpenAI provider to take in rpm/pace and use it for controlling rate of endpoint invocations.