wip: parse --results flag

main.go

@@ -50,7 +50,7 @@ var (
 	concurrency         = cli.Flag("concurrency", "Number of concurrent workers.").Default(strconv.Itoa(runtime.NumCPU())).Int()
 	noVerification      = cli.Flag("no-verification", "Don't verify the results.").Bool()
 	onlyVerified        = cli.Flag("only-verified", "Only output verified results.").Hidden().Bool()
-	results             = cli.Flag("results", "Specifies which type(s) of results to output: verified, unknown, unverified. This flag can be repeated. Defaults to all types.").Enums("verified", "unknown", "unverified")
+	results             = cli.Flag("results", "Specifies which type(s) of results to output: verified, unknown, unverified. This flag can be repeated. Defaults to all types.").Default("verified,unknown").String()
 
 	allowVerificationOverlap = cli.Flag("allow-verification-overlap", "Allow verification of similar credentials across detectors").Bool()
 	filterUnverified         = cli.Flag("filter-unverified", "Only output first unverified result per chunk per detector if there are more than one results.").Bool()
@@ -409,7 +409,7 @@ func run(state overseer.State) {
 	}
 
 	if *onlyVerified {
-		r := []string{"verified"}
+		r := "verified"
 		results = &r
 	}
 

pkg/engine/engine.go

@@ -7,14 +7,15 @@ import (
 	"fmt"
 	"io"
 	"runtime"
+	"slices"
+	"strings"
 	"sync"
 	"sync/atomic"
 	"time"
 
 	"github.com/adrg/strutil"
 	"github.com/adrg/strutil/metrics"
 	lru "github.com/hashicorp/golang-lru/v2"
-	"golang.org/x/exp/slices"
 	"google.golang.org/protobuf/proto"
 
 	"github.com/trufflesecurity/trufflehog/v3/pkg/common"
@@ -167,20 +168,28 @@ func WithFilterEntropy(entropy float64) Option {
 	}
 }
 
-// WithResults sets the |logVerificationErrors| flag on the engine.
-// If set to true, the engine will print results with verification errors,
-// even if the result is unverified and |onlyVerified| is true.
-func WithResults(results []string) Option {
+var expectedResults = []string{"verified", "unknown", "unverified"}
+
+// WithResults defines which results will be printed by the engine.
+func WithResults(results string) Option {
 	return func(e *Engine) {
-		if len(results) > 0 {
-			if slices.Contains(results, "verified") {
-				e.notifyVerifiedResults = true
-			}
-			if slices.Contains(results, "unknown") {
-				e.notifyUnknownResults = true
-			}
-			if slices.Contains(results, "unverified") {
-				e.notifyUnverifiedResults = true
+		values := strings.Split(strings.ToLower(results), ",")
+
+		if len(values) > 0 {
+			for _, value := range values {
+				if slices.Contains(expectedResults, value) {
+					switch value {
+					case "verified":
+						e.notifyVerifiedResults = true
+					case "unknown":
+						e.notifyUnknownResults = true
+					case "unverified":
+						e.notifyUnverifiedResults = true
+					}
+				} else {
+					// TODO: Log/handle this error.
+					fmt.Printf("Uh oh!")
+				}
 			}
 		} else {
 			e.notifyVerifiedResults = true