Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not override base parameter with default in GitHub Action #1004

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: do not override base parameter with default in GitHub Action #1004

merged 1 commit into from
Jan 10, 2023

Conversation

clarkedb
Copy link
Contributor

@clarkedb clarkedb commented Jan 8, 2023

This reverts #999 which mistakenly makes the base parameter for GitHub actions useless because it always sends the default value for base into the --since-commit flag. Furthermore that default value is '' which breaks so trufflehog cannot run.

I believe that if base is not specified, then the input.base.default value will be used automatically when accessing input.base. There is no need to add default, and doing so only ever gets the default value.

Closes #1002

@clarkedb clarkedb requested a review from a team as a code owner January 8, 2023 15:30
@clarkedb clarkedb mentioned this pull request Jan 8, 2023
Closed
@rob-baldwin rob-baldwin mentioned this pull request Jan 9, 2023
Closed
mcastorina
mcastorina approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

@mcastorina mcastorina merged commit 864cf00 into trufflesecurity:main Jan 10, 2023
@Huskydog9988 Huskydog9988 mentioned this pull request Jan 10, 2023
Closed
@clarkedb clarkedb deleted the fix-gh-action-do-not-override-base-input-with-default branch January 10, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing argument for since-commit
2 participants
@clarkedb @mcastorina