Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy metadata for line number aware sources #1011

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Copy metadata for line number aware sources #1011

merged 2 commits into from
Jan 10, 2023

Conversation

bill-rich
Copy link
Collaborator

Multiple results from the same chunk could result in line numbers in the metadata being overwritten. Deep copy the chunk and source metadata to avoid clobbering.

@bill-rich bill-rich requested a review from a team as a code owner January 9, 2023 19:22
mcastorina
mcastorina reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one concern about SetResultLineNumber.

pkg/engine/engine.go Outdated Show resolved Hide resolved
pkg/engine/engine.go Show resolved Hide resolved
@bill-rich bill-rich merged commit 8b2e1d3 into main Jan 10, 2023
@bill-rich bill-rich deleted the OC-230_copy_metadata_for_results branch January 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bill-rich @mcastorina