Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update entrypoint #1013

Merged
merged 12 commits into from
Jan 12, 2023
Merged

Update entrypoint #1013

merged 12 commits into from
Jan 12, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Jan 9, 2023 •
edited

Tested it on a personal project and it looks to be working.

Screen Shot 2023-01-11 at 5 45 53 PM

@ahrav ahrav requested a review from a team as a code owner January 9, 2023 20:18
mcastorina
mcastorina reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of those changes that's small but scary 😆

Have you done any tests to make sure it doesn't completely break everything?

entrypoint.sh Outdated Show resolved Hide resolved
@ahrav
Copy link
Collaborator Author

ahrav commented Jan 9, 2023

This is one of those changes that's small but scary 😆

Have you done any tests to make sure it doesn't completely break everything?

I'm thinking of creating a test release from this branch to see what happens.

@ahrav ahrav requested review from mcastorina and a team January 11, 2023 23:44
@ahrav ahrav changed the title Update entrypoint. Update entrypoint Jan 12, 2023
@ahrav ahrav merged commit 477e2a1 into main Jan 12, 2023
@ahrav ahrav deleted the update-entrypoint-script branch January 12, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcastorina mcastorina mcastorina approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahrav @mcastorina