Detector-Competition-Fix: Fix AppFollow Detection & Verification #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zricethezav
reviewed
Oct 23, 2023
zricethezav
added
the
Hacktoberfest-Detector-Competition-Fix
rgmz
reviewed
Oct 23, 2023
zricethezav
approved these changes
Oct 30, 2023
Blissful304
approved these changes
Apr 26, 2024
Blissful304
approved these changes
Apr 26, 2024
Blissful304
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes AppFollow detection and verification. AppFollow uses JWTs for API keys and has changed the header you're required to send:
Furthermore, the
https://api.appfollow.io/testendpoint has been removed and 404's when you send verification.Changed the regular expression to match JWTs and now perform validation by requesting
https://api.appfollow.io/api/v2/account/usersChecklist:
make test-community)?make lintthis requires golangci-lint)?