-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shallow cloning + GitHub Action #2138
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5df08af
proposed shallow cloning gh action
joeleonjr 7542ef4
removing unnecessary steps
joeleonjr 35d5904
adding back in git checkout
joeleonjr 3e4331f
removed git cloning + added backward compatibility
joeleonjr 481dee1
Merge branch 'main' into gh-action-shallow-clone
joeleonjr a36d43e
Merge branch 'main' into gh-action-shallow-clone
joeleonjr 9404936
Merge branch 'main' into gh-action-shallow-clone
joeleonjr c6adf3d
Merge branch 'main' into gh-action-shallow-clone
joeleonjr d23f941
Merge branch 'main' into gh-action-shallow-clone
joeleonjr 7fb15ec
Merge branch 'main' into gh-action-shallow-clone
joeleonjr 9975df5
Merge branch 'main' into gh-action-shallow-clone
joeleonjr ed87b09
Merge branch 'main' into gh-action-shallow-clone
joeleonjr dbb236e
Merge branch 'main' into gh-action-shallow-clone
joeleonjr d82761d
Merge branch 'main' into gh-action-shallow-clone
joeleonjr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought (non-blocking): I could see how users might want to scan a single commit. As a user I don't want to determine the range, I just want to provide a single commit. We could change the base==head behavior to scan base/head against closets parent commit.
Just a thought, this isn't blocking and we could revisit this down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a valid use case. I'm open to adjusting this. I think we should ship this asap since some folks aren't scanning commits atm and think they are. But I'm down to think through what the behavior should look like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately, I'm reviewing this code before merging in and I'm looking at this line
if [ $base_commit == $head_commit ] ; then
. Do you think there are folks that leavebase
equal to''
andhead
equal to''
, so that they can trigger a full git repository history scan? @zricethezav