Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] - add additional binary extensions to skip #2235

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[chore] - add additional binary extensions to skip #2235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf2b877
add additional binary extensions to skip
ahrav Dec 16, 2023
cd1b67b
remove whl
ahrav Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/common/vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ var (
"wav",
"flac",
"webp",
"pdf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how sure are we about this? these can presumably be opened up and inspected, right? do we get false positives from them or something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen a result in a PDF unless it has gone through a PDF handler (not yet released)


// images
"png",
Expand Down Expand Up @@ -79,6 +80,9 @@ var (
"vxd": {}, // Virtual device driver in Windows
"sfx": {}, // Self-extracting archive
"bundle": {}, // Mac OS X application bundle
"pyo": {}, // Compiled Python file
"pyc": {}, // Compiled Python file
"sym": {}, // Symbolic link, Unix/Linux
}
)

Expand Down
Loading