[bug] - Correctly return the checked out buffer to the pool #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
reviewed
Apr 23, 2024
| @@ -172,6 +172,10 @@ func (w *BufferedFileWriter) CloseForWriting() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Return the buffer to the pool since the contents have been written to the file and | |||
| // the writer is transitioning to read-only mode. | |||
| w.bufPool.Put(w.buf) | |||
There was a problem hiding this comment.
Does this free up the buffer for use elsewhere? That seems incompatible with reading from it below.
There was a problem hiding this comment.
Whoops, this was meant to be in a defer. I also clearly missed the failing test which would've also caught this. 馃槗
dustin-decker
approved these changes
Apr 23, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR ensures that the
BufferedFileWriterreturns its underlying buffer to the pool upon being closed after writing.馃槄
Checklist:
make test-community)?make lintthis requires golangci-lint)?