Update HubSpot detectors #2845
Open
Update HubSpot detectors #2845
+507
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
force-pushed
the
feat/hubspotv1-update
branch
5 times, most recently
from
425fa83
to
2dc1279
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
3 times, most recently
from
f881f05
to
43fc620
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
2 times, most recently
from
c319443
to
307d7d0
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
3 times, most recently
from
b50418d
to
1b4ca8a
Compare
|
|
rgmz
force-pushed
the
feat/hubspotv1-update
branch
2 times, most recently
from
af8c7c9
to
1a7e796
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
1a7e796
to
3f73810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This changes the HubSpot v1 detector to tri-state verification and adds two other common keywords.
hubapithe actual domain associated with the HubSpot APIhapikeythe query parameter used to pass in legacy authIt also merges in changes from #2369 to align the implementations, and add unit tests to both.
Checklist:
make test-community)?make lintthis requires golangci-lint)?